You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this class would benefit greatly from separating the $html, $css and $cssRules properties (data) and the data processing methods.
Currently people are having issues because all of the conversion is done in one method, using internal properties for their data.
See #106 and #87
If the css and html data could be injected into a conversion method, we could cache (css-rule) data externally if needed and inject cached data if needed.
Also memory issues will be a thing of the past.
We could keep the current class as wrapper for backwards compatibility to keep containing html and css data like the current class and move the html processing to a separate class. This publicly available class for css processing could then be used in different projects that want to manage their css and html data outside of the conversion class.
I think this class would benefit greatly from separating the
$html
,$css
and$cssRules
properties (data) and the data processing methods.Currently people are having issues because all of the conversion is done in one method, using internal properties for their data.
See #106 and #87
If the css and html data could be injected into a conversion method, we could cache (css-rule) data externally if needed and inject cached data if needed.
Also memory issues will be a thing of the past.
We could keep the current class as wrapper for backwards compatibility to keep containing html and css data like the current class and move the html processing to a separate class. This publicly available class for css processing could then be used in different projects that want to manage their css and html data outside of the conversion class.
Also see #87 (comment)
The text was updated successfully, but these errors were encountered: