Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the css, html and cssRules as properties (keep wrapper class for BC) #109

Closed
Hikariii opened this issue Oct 13, 2015 · 1 comment
Closed

Comments

@Hikariii
Copy link
Contributor

I think this class would benefit greatly from separating the $html, $css and $cssRules properties (data) and the data processing methods.

Currently people are having issues because all of the conversion is done in one method, using internal properties for their data.
See #106 and #87

If the css and html data could be injected into a conversion method, we could cache (css-rule) data externally if needed and inject cached data if needed.
Also memory issues will be a thing of the past.

We could keep the current class as wrapper for backwards compatibility to keep containing html and css data like the current class and move the html processing to a separate class. This publicly available class for css processing could then be used in different projects that want to manage their css and html data outside of the conversion class.

Also see #87 (comment)

@tijsverkoyen
Copy link
Owner

This will be fixed in #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants