add sanitizer #17
Merged
add sanitizer #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
BusyJay
reviewed
Oct 14, 2020
|
|
||
| proto: proto/proto/meta.proto proto/proto/rustproto.proto |
There was a problem hiding this comment.
Now we use prost-build to generate meta.rs on cargo build, instead of generating them manually.
Run all sanitizer bench takes ~40mins, and unsafe code is mostly used in skiplists. So I choose to run sanitizer bench only on there's any change in skiplist. Maybe we could run this bench manually instead of triggering by PR or commit, and I could include all modules in bench? |
Seems more practical. |
Signed-off-by: Alex Chi <iskyzh@gmail.com>
|
I've updated the CI config. After this PR being merged, we could manually trigger sanitizer test and bench on GitHub Action webpage. |
Signed-off-by: Alex Chi <iskyzh@gmail.com>
BusyJay
approved these changes
Oct 14, 2020
|
Now benchmark can be triggered in Action tab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Chi iskyzh@gmail.com
fix #10
Sanitizer will only run when there's any change in
skiplistmodule. First successful run is triggered along withsplit sanitizercommit.In the future, we could apply sanitizer to other modules.