Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Tracking issue for database persistence #64

Closed
skyzh opened this issue Nov 25, 2020 · 1 comment
Closed

[dev] Tracking issue for database persistence #64

skyzh opened this issue Nov 25, 2020 · 1 comment

Comments

@skyzh
Copy link
Member

skyzh commented Nov 25, 2020

Currently, we simply delete table files after we drop the last reference Arc to TableInner. This causes several issues.

@skyzh skyzh added this to In progress in agatedb preview Dec 1, 2020
@skyzh
Copy link
Member Author

skyzh commented Dec 2, 2020

The leak issue has been fixed in 0ce60db

Current solution is that:

  • We add a save_after_close atomic bool in related structure.
  • If we need this file in next database load, we mark this structure as not to delete.
  • If save_after_close is set when dropping Wal or SST, we don't delete the corresponding file.

@skyzh skyzh closed this as completed Dec 2, 2020
agatedb preview automation moved this from In progress to Done Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant