Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] panic on drop causes process to abort #89

Closed
skyzh opened this issue Dec 16, 2020 · 5 comments
Closed

[dev] panic on drop causes process to abort #89

skyzh opened this issue Dec 16, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@skyzh
Copy link
Member

skyzh commented Dec 16, 2020

As seen in failed CI in #88 , agatedb will abort when we panic on drop. I implemented a partial solution the we ignore all failures (e.g. PoisonedLock, failed to remove file) and simply print them. We could later find a better way to solve this issue.

@skyzh skyzh added the bug Something isn't working label Dec 16, 2020
@skyzh
Copy link
Member Author

skyzh commented Dec 16, 2020

Generally, this should not abort, as panic on drop should panic as-is. However, what we may encounter is that, we have panicked, and when rewinding stack to drop, another panic happens. This would cause process abort with no further information.

@skyzh skyzh added this to In progress in agatedb preview Dec 16, 2020
@skyzh
Copy link
Member Author

skyzh commented Dec 16, 2020

SST lost before drop

image

@skyzh
Copy link
Member Author

skyzh commented Dec 16, 2020

This bug is introduced by #87 , where we for the first time enable Agate to be cloned. When an Agate got dropped, all related channels will be closed, and the thread pool will be shutdown. We should wrap Agate with an Arc.

@de-sh
Copy link

de-sh commented Mar 19, 2021

Is this solved @skyzh?

@skyzh
Copy link
Member Author

skyzh commented Mar 19, 2021

Is this solved @skyzh?

Yes. I think I could close this issue for now.

@skyzh skyzh closed this as completed Mar 19, 2021
agatedb preview automation moved this from In progress to Done Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants