Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return full region detail for /region API #1223

Closed
disksing opened this issue Aug 29, 2018 · 1 comment · Fixed by #1252
Closed

Return full region detail for /region API #1223

disksing opened this issue Aug 29, 2018 · 1 comment · Fixed by #1252
Labels
component/api HTTP API. status/TODO The issue will be done in the future.

Comments

@disksing
Copy link
Contributor

Currently it only returns region meta, see: https://github.com/pingcap/pd/blob/f89771a4044c09b4f8cf67d7db8d72c4542556e3/server/api/region.go#L134-L138

Incomplete information can cause trouble when we want to find some regions. I think we can return full region information after done refactoring region clone.

/cc @nolouch
@disksing disksing added status/TODO The issue will be done in the future. component/api HTTP API. labels Aug 29, 2018
@WalterWj
Copy link

great

@liukun4515 liukun4515 mentioned this issue Sep 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/api HTTP API. status/TODO The issue will be done in the future.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pd-ctl: return full region information for /region api liukun4515/pd
2 participants
@disksing @WalterWj