Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider evict leader after offline the store #3563

Closed
nolouch opened this issue Apr 2, 2021 · 6 comments
Closed

Consider evict leader after offline the store #3563

nolouch opened this issue Apr 2, 2021 · 6 comments
Labels
type/enhancement The issue belongs to an enhancement.

Comments

@nolouch
Copy link
Contributor

nolouch commented Apr 2, 2021

Feature Request

Describe your feature request related problem

TiKV snapshot has an IO limit of 100MB/s. it's may become a bottleneck for sending snapshots. in the big cluster, we have encountered it about add learner too slow.

Describe the feature you'd like

  • Consider evicting leader after offline the store, then we can get snapshot from anthoer store.

Teachability, Documentation, Adoption, Migration Strategy

  • Go
@nolouch nolouch added type/enhancement The issue belongs to an enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 2, 2021
@xuhui-lu
Copy link
Contributor

xuhui-lu commented Apr 6, 2021

Hey @nolouch, is this issue still open? If so, I can spend some time this week to help implement it.

@nolouch
Copy link
Contributor Author

nolouch commented Apr 6, 2021

Thanks, @xuhui-lu, you can do it. and if you have any problem, you can ask about it in this issue.

@rleungx
Copy link
Member

rleungx commented Apr 6, 2021

Hey @nolouch, is this issue still open? If so, I can spend some time this week to help implement it.

There is a case that needs to pay attention to. If the number of offline stores is more than the rest, evict leaders may be not a good way.

@xuhui-lu
Copy link
Contributor

xuhui-lu commented Apr 8, 2021

Hey @nolouch, is this issue still open? If so, I can spend some time this week to help implement it.

There is a case that needs to pay attention to. If the number of offline stores is more than the rest, evict leaders may be not a good way.

oh, right. If the number of offline stores is more than the rest, evict leaders will lead to continuous election failures.

@nolouch
Copy link
Contributor Author

nolouch commented Jun 2, 2021

I found a corner case that if we deploy the cluster in cross-region. evict leader may let the snapshot task cross region,It would be worse. maybe the better solution is the follower replica tikv/raft-rs#136. Do we have any plan to support it? cc @BusyJay

@nolouch
Copy link
Contributor Author

nolouch commented Jun 2, 2021

But the problem also exists in the store is down in the cross-region situation. the optimize can be done in the future.

@nolouch nolouch removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 2, 2021
@nolouch nolouch closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants