New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create schedulers base on configuration. #738

Closed

disksing opened this issue Sep 6, 2017 · 1 comment

Assignees

Labels

Contributor

disksing commented Sep 6, 2017 •

edited

Now schedulers are initially created statically: https://github.com/pingcap/pd/blob/5cb02b14cd67457f3328c773cfee969241790869/server/coordinator.go#L128-L134

We can also add/remove schedulers at runtime:
https://github.com/pingcap/pd/blob/7b9052c149bab4febdf685aaa1b64ca4680b4303/server/handler.go#L71
https://github.com/pingcap/pd/blob/7b9052c149bab4febdf685aaa1b64ca4680b4303/server/handler.go#L80

We need to do:

make it configurable, support load initial schedulers' names from config file.
after add/remove a scheduler, the schedulers list should persist to etcd. So the schedulers can be recreate after leader change or pd-server restart.

disksing added the status/TODO label

disksing assigned Connor1996

Member

Connor1996 commented Sep 30, 2017

Connor1996 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment