Prevent underflow with CPU time counter #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nox
force-pushed
the
cpu-total-underflow
branch
from
ccf534c
to
039c5dd
Compare
|
Thanks for the PR! I've left a minor comment in review. Did you hit this in the wild? How did you end up having multiple |
You didn't.
You don't need multiple process collectors, only multiple threads collecting the global registry at the same time. |
nox
force-pushed
the
cpu-total-underflow
branch
from
039c5dd
to
3567368
Compare
lucab
reviewed
Oct 20, 2022
nox
force-pushed
the
cpu-total-underflow
branch
from
3567368
to
f1d1524
Compare
Signed-off-by: Anthony Ramine <nox@nox.paris>
nox
force-pushed
the
cpu-total-underflow
branch
from
f1d1524
to
1ee91a5
Compare
JanBerktold
pushed a commit
to JanBerktold/rust-prometheus
that referenced
this pull request
Nov 12, 2022
Signed-off-by: Anthony Ramine <nox@nox.paris> Signed-off-by: Anthony Ramine <nox@nox.paris> Signed-off-by: Jan Berktold <jberktold@roblox.com>
JanBerktold
pushed a commit
to JanBerktold/rust-prometheus
that referenced
this pull request
Nov 12, 2022
Signed-off-by: Anthony Ramine <nox@nox.paris> Signed-off-by: Anthony Ramine <nox@nox.paris>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.