Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade RocksDB to 5.18 #282

Closed
yiwu-arbug opened this issue Mar 21, 2019 · 4 comments
Closed

Upgrade RocksDB to 5.18 #282

yiwu-arbug opened this issue Mar 21, 2019 · 4 comments
Assignees
@yiwu-arbug

Comments

@yiwu-arbug
Copy link
Collaborator

Current rocksdb fork is based on rocksdb 5.15, which is half a year old.
@yiwu-arbug yiwu-arbug mentioned this issue Mar 21, 2019
Merged
@yiwu-arbug
Copy link
Collaborator Author

yiwu-arbug commented Mar 21, 2019 •
edited
Loading

Currently test_set_external_sst_file_global_seq_no is failing. This is because rocksdb introduces ingest_external_file_options.write_global_seqno and default to false. Will set it to true on tikv side for now, and work on turning it on later.

@yiwu-arbug
Copy link
Collaborator Author

Actually write_global_seqno defaults to true and the test failure can be workaround.

@yiwu-arbug yiwu-arbug self-assigned this Mar 22, 2019
@yiwu-arbug
Copy link
Collaborator Author

Fix on rocksdb side with facebook/rocksdb#5097

@yiwu-arbug
Copy link
Collaborator Author

Created tag tikv3.0.0-beta1 with the above fix before it is merged in rocksdb. Updated PR #280.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yiwu-arbug yiwu-arbug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yiwu-arbug