Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The need_restored_data for multi value index should return false #15531

Closed
YangKeao opened this issue Sep 5, 2023 · 3 comments
Closed

The need_restored_data for multi value index should return false #15531

YangKeao opened this issue Sep 5, 2023 · 3 comments
Labels
affects-7.5 may-affects-5.3 may-affects-5.4 may-affects-6.1 may-affects-6.5 may-affects-7.1 severity/major sig/coprocessor SIG: Coprocessor type/bug Type: Issue - Confirmed a bug

Comments

@YangKeao
Copy link
Member

YangKeao commented Sep 5, 2023 •
edited

In tidb, need_restored_data for multi value index should return false, as the tp will become JSON when it's marked as an array. I'm not sure whether it's good to modify get_tp() to return json for every type, but at least we should ignore the RestoredData for json, or it will report an error.
@YangKeao YangKeao added the type/bug Type: Issue - Confirmed a bug label Sep 5, 2023
@YangKeao YangKeao changed the title Not all columns are included in the RestoreData. Not all columns should have been included in the RestoreData. Sep 5, 2023
@YangKeao YangKeao changed the title Not all columns should have been included in the RestoreData. The need_restored_data for multi value index should return false Sep 5, 2023
@YangKeao YangKeao mentioned this issue Sep 6, 2023
Closed
2 tasks
@YangKeao
Copy link
Member Author

YangKeao commented Sep 6, 2023

This issue also affects 7.1

@tonyxuqqi tonyxuqqi added the sig/coprocessor SIG: Coprocessor label Oct 23, 2023
@tonyxuqqi
Copy link
Contributor

cc @Benjamin2037

@YangKeao
Copy link
Member Author

This issue should have been closed by pingcap/tidb#46993. TiDB will set the collation of multi-valued index as binary. Sorry, I forgot to close it after merging #46993.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.5 may-affects-5.3 may-affects-5.4 may-affects-6.1 may-affects-6.5 may-affects-7.1 severity/major sig/coprocessor SIG: Coprocessor type/bug Type: Issue - Confirmed a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor, expression: add support for array type YangKeao/tikv
4 participants
@jebter @YangKeao @tonyxuqqi @ti-chi-bot