Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd_client: make update_service_gc_safepoint return error when the safepoint wasn't uploaded. #16910

Closed
YuJuncen opened this issue Apr 24, 2024 · 0 comments · Fixed by #16911
Closed

pd_client: make update_service_gc_safepoint return error when the safepoint wasn't uploaded. #16910

YuJuncen opened this issue Apr 24, 2024 · 0 comments · Fixed by #16911
Labels
type/enhancement Type: Issue - Enhancement

Comments

@YuJuncen
Copy link
Contributor

Development Task

For now, this function was only called by br-stream. Which in fact doesn't have well defined behavior (but just logging) when encountering failed to upload service GC safepoint. So in fact the lack of error reporting won't really make things worse. But anyway the API is then get pretty weird, we need to enhance it.
@YuJuncen YuJuncen added the type/enhancement Type: Issue - Enhancement label Apr 24, 2024
@YuJuncen YuJuncen mentioned this issue Apr 24, 2024
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this issue Apr 29, 2024
@YuJuncen
pd_client: make update_service_safe_point returns error when stale (#…
419dacd 
…16911)

close #16910

Let `update_service_safe_point` return an error when the provided service gc safepoint is stale.

Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: Yu Juncen <yu745514916@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Type: Issue - Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pd_client: make update_service_safe_point returns error when stale YuJuncen/tikv
1 participant
@YuJuncen