Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is it suitable to use specified compression for snapshot SST implicitly? #2536

Open
siddontang opened this issue Dec 1, 2017 · 4 comments
Open
Labels
status/discussion Status: Under discussion or need discussion

Comments

@siddontang
Copy link
Contributor

Now we forcibly use fast compression for snapshot SST, but some users may don't want use any compression. We may use the same compression set in the config file.

/cc @zhangjinpeng1987 @huachaohuang

@siddontang siddontang added the status/discussion Status: Under discussion or need discussion label Dec 1, 2017
@zhangjinpeng87
Copy link
Member

zhangjinpeng87 commented Dec 1, 2017

We used a fast compression for snapshot SST was partly because we don't want to use an expensive compression which will take some time to generate the snapshot, and also we don't want the content is too large when delivering on network.

@siddontang
Copy link
Contributor Author

If the user doesn't install LZ4 or want to use their own compression type later, how can we support?

@siddontang
Copy link
Contributor Author

Seem it is hard for the user to add their own compression lib, they should not only change rust-rocksdb, but also need to change TiKV in some places.

See tikv/rust-rocksdb#152

@huachaohuang
Copy link
Contributor

We actually choose the fast compression algorithm from supported algorithms, which sounds reasonable to me. However, in that specific case, I guess something may be wrong, but I am not sure what's wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/discussion Status: Under discussion or need discussion
Projects
None yet
Development

No branches or pull requests

3 participants