*: check memory locks in replica read #8926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
…ex-2 Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
…ad-index Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
…ad-index-2 Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
sticnarf
requested review from
5kbpers,
MyonKeminta,
NingLin-P and
youjiali1995
|
I am not so confident in the raftstore changes. Please be careful in checking whether all paths of replica read are covered. This PR mixes a lot of transaction related code into raftstore. This makes me feel uncomfortable... Code style and organization suggestions are welcome. |
|
/run-all-tests |
Can you put them into coprocessor? |
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Nov 12, 2020
BusyJay
reviewed
Nov 12, 2020
| @@ -3471,6 +3516,127 @@ fn make_transfer_leader_response() -> RaftCmdResponse { | |||
| resp | |||
| } | |||
|
|
|||
| const UUID_LEN: usize = 16; | |||
There was a problem hiding this comment.
Can it be moved out of peer.rs, like read_queue.rs? It's large enough.
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
NingLin-P
reviewed
Nov 12, 2020
Comment on lines
1033
to
1037
| if ctx.coprocessor_host.on_step_read_index(&mut m) { | ||
| return Ok(self.raft_group.step(m)?); | ||
| } | ||
| // Here we hold up MsgReadIndex. If current peer has valid lease, then we could handle the | ||
| // request directly, rather than send a heartbeat to check quorum. |
There was a problem hiding this comment.
Even though there are memory locks encountered, I think we can still utilize the leader lease to avoid broadcasting a heartbeat to check quorum. /cc @5kbpers
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
|
LGTM |
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
…narf/tikv into mem-lock-check-read-index-2
|
/merge |
|
/run-all-tests |
|
@sticnarf merge failed. |
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: tikv/sig-transaction#20
Problem Summary: Replica read in TiKV currently conflicts with async commit.
What is changed and how it works?
Depends on pingcap/kvproto#687
This PR changes the read index context from a UUID to something more complex. Now the context may contain the range to check and also may contain the lock returned by the leader. When a leader receives a read index context with key ranges, it will check the in-memory lock table and see if there is any lock blocking this read. If any, it will send the lock back to the follower or learner via the read index context.
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tidb-ansible:Check List
Tests
There should be more tests for each reading RPC. We can add them later.
Release note