Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile in try/4.0/docker-stack.md #214

Closed
Terkwood opened this issue Dec 11, 2020 · 0 comments · Fixed by #215
Closed

Fix Dockerfile in try/4.0/docker-stack.md #214

Terkwood opened this issue Dec 11, 2020 · 0 comments · Fixed by #215

Comments

@Terkwood
Copy link
Contributor

Terkwood commented Dec 11, 2020

Change Request

The Dockerfile used to build the client example app in https://tikv.org/docs/4.0/tasks/try/docker-stack/ does not work.

Describe the problem

non-interactive install for tzdata

I used DEBIAN_FRONTEND="noninteractive", so that tzdata would not prompt during installation. I also had to use apt-get instead of apt!

RUN DEBIAN_FRONTEND="noninteractive" apt-get install --yes build-essential protobuf-compiler curl cmake golang libssl-dev

rust stable has async await

The doc website incorrectly requires a nightly rust toolchain. This is no longer necessary since async/await functionality has landed in rust stable. I removed all references to the version-hacking file rust-toolchain.

# ...snip...
# Install Rust
RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
ENV PATH="/builder/.cargo/bin:${PATH}"

# Fetch, then prebuild all deps
COPY Cargo.toml /builder/build/

Missing libssl-dev

I also had to install libssl-dev.

RUN DEBIAN_FRONTEND="noninteractive" apt-get install --yes build-essential protobuf-compiler curl cmake golang libssl-dev

Suggest an improvement/fix

I will raise a PR presently to address this issue.

Thank you for taking the time to review this request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant