Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make article's title and left-menu fixed #19

Closed
andreantonacci opened this issue Jan 8, 2021 · 7 comments
Closed

make article's title and left-menu fixed #19

andreantonacci opened this issue Jan 8, 2021 · 7 comments
Assignees

Comments

@andreantonacci
Copy link
Member

Make the title and the left-menu FIXED. They should always be there, they should not scroll down together with the article. Only the article scrolls down.

@heyarviind
Copy link
Collaborator

I have made it fixed, but due to the fixed navbar, it is overlapping...

Screenshot 2021-01-08 at 10 40 18 PM

@andreantonacci
Copy link
Member Author

Arvind, it appears to me that you made it sticky, not fixed. I don't really know myself which one works best for this occasion, but this how we want it to look:

Screen.Recording.2021-01-11.at.11.04.05.mov

I made it using position fixed and removing top: 0. HOWEVER, now it continues scrolling over the footer, which we don't want. It should stop before. Perhaps it's position sticky, but with a bottom value instead of top?

@andreantonacci
Copy link
Member Author

And obviously we don't want the title to go over the article on the right...

@andreantonacci
Copy link
Member Author

Now it's way better. It stops before the footer. However, when you scroll down it gets very close to the footer and it doesn't look good. Please add some margin to the left-menu.

I did it here adding it some margin-bottom to .col-lg-8, not sure if it's the proper way of doing it. But this is the idea.

Screen.Recording.2021-01-12.at.10.10.38.mov

@andreantonacci
Copy link
Member Author

I see that this issue has been fixed but not everywhere. For instance, the menu still gets very close to the footer in the Educational Videos tutorial for some reason.

image

@heyarviind
Copy link
Collaborator

I have added the space, but there is a bug like when you click on the link and it scrolls automatically, left menu overlaps the footer in some cases

@andreantonacci
Copy link
Member Author

I think you're referring to the bug I mentioned on issue #25 - please fix it because it's very disturbing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants