Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total audio crash #1461

Closed
freq-mod opened this issue Sep 7, 2023 · 6 comments
Closed

Total audio crash #1461

freq-mod opened this issue Sep 7, 2023 · 6 comments
Assignees
Labels
bug Something isn't working critical Requires urgent fixing done issue resolved

Comments

@freq-mod
Copy link
Collaborator

freq-mod commented Sep 7, 2023

Yes. Literally doing so as soon as opening furnace crashes with:
furnace: /home/anon/furnace/src/engine/blip_buf.c:210: blip_read_samples: Assertion `count >= 0' failed.
Stack trace (most recent call last) in thread 9355:
#18 Object "[0xffffffffffffffff]", at 0xffffffffffffffff, in
#17 Object "/usr/lib/libc.so.6", at 0x7faba8d10dfb, in
#16 Object "/usr/lib/libc.so.6", at 0x7faba8c8c9ea, in
#15 Object "/usr/lib/libSDL2-2.0.so.0", at 0x7faba9744c0a, in
#14 Object "/usr/lib/libSDL2-2.0.so.0", at 0x7faba96352e0, in
#13 Object "furnace", at 0x5570fbafbfd6, in taSDLProcess(void*, unsigned char*, int)
#12 Object "furnace", at 0x5570fbafc081, in TAAudioSDL::onProcess(unsigned char*, int)
#11 Object "furnace", at 0x5570fb8aaaed, in process(void*, float**, float**, int, int, unsigned int)
#10 Object "furnace", at 0x5570fb94dce3, in DivEngine::nextBuf(float**, float**, int, int, unsigned int)
#9 Object "furnace", at 0x5570fb887efc, in DivWorkPool::push(void ()(void), void*)
#8 Object "furnace", at 0x5570fb94c186, in
#7 Object "furnace", at 0x5570fb94c166, in
#6 Object "furnace", at 0x5570fb899282, in DivDispatchContainer::fillBuf(unsigned long, unsigned long, unsigned long)
#5 Object "furnace", at 0x5570fb88492a, in blip_read_samples
#4 Object "/usr/lib/libc.so.6", at 0x7faba8c36d25, in __assert_fail
#3 Object "/usr/lib/libc.so.6", at 0x7faba8c263db, in
#2 Object "/usr/lib/libc.so.6", at 0x7faba8c264b7, in abort
#1 Object "/usr/lib/libc.so.6", at 0x7faba8c3e667, in raise
#0 Object "/usr/lib/libc.so.6", at 0x7faba8c8e83c, in
Aborted (Signal sent by tkill() 9352 1000)
Przerwane (zrzut pamięci)

Not a heisenbug, 100% replicable, affects at the very least linux, most likely everyone. How did it slip through? fresh master btw

@freq-mod freq-mod added bug Something isn't working critical Requires urgent fixing labels Sep 7, 2023
@freq-mod
Copy link
Collaborator Author

freq-mod commented Sep 7, 2023

Pressing any note = crash, furnace is completely broken now

@freq-mod
Copy link
Collaborator Author

freq-mod commented Sep 7, 2023

EDIT 2: only JACK works now. SDL and PortAudio do crash

@freq-mod freq-mod changed the title [CRITICAL BUG] Pressing Q = instant crash [CRITICAL BUG] Pressing any key = instant crash Sep 7, 2023
@ElectricKeet
Copy link
Collaborator

Win10 x64, SDL, WASAPI:
I find that it stops crashing when audioBufSize is greater than 256.

@tildearrow tildearrow changed the title [CRITICAL BUG] Pressing any key = instant crash Pressing any key = instant crash Sep 7, 2023
@tildearrow tildearrow self-assigned this Sep 7, 2023
@tildearrow tildearrow added the feedback Further information is requested label Sep 7, 2023
@tildearrow
Copy link
Owner

Please test with Git master. I pushed a fix.

@tildearrow tildearrow changed the title Pressing any key = instant crash Total audio crash Sep 7, 2023
@freq-mod freq-mod closed this as completed Sep 7, 2023
@tildearrow
Copy link
Owner

Do not close until we have enough confirmation.

@tildearrow tildearrow reopened this Sep 7, 2023
@tildearrow
Copy link
Owner

OK - several users confirm fix to be effective.

@tildearrow tildearrow added done issue resolved and removed feedback Further information is requested labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical Requires urgent fixing done issue resolved
Projects
None yet
Development

No branches or pull requests

3 participants