Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Critical Bug] Furnace crashes on renaming instrument with non standard symbols in name #550

Closed
freq-mod opened this issue Jun 21, 2022 · 1 comment
Assignees
Labels
bug Something isn't working critical Requires urgent fixing done issue resolved

Comments

@freq-mod
Copy link
Collaborator

freq-mod commented Jun 21, 2022

backup.fur.zip - backup module.

STEPS TO REPRODUCE:

  1. Load this module
  2. Select Instrument 1 (the one with funny chars, imported from FF bank)
  3. Highlight the name
  4. Press any key you like

furnace: /home/anon/furnace/extern/imgui_patched/imgui_widgets.cpp:4548: bool ImGui::InputTextEx(const char*, const char*, char*, int, const ImVec2&, ImGuiInputTextFlags, ImGuiInputTextCallback, void*): Assertion `apply_new_text_length >= 0' failed.
Stack trace (most recent call last):
#12 Object "[0xffffffffffffffff]", at 0xffffffffffffffff, in
#11 Object "furnace", at 0x5604fb6b32b9, in _start
#10 Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7f45bd84a7fc, in __libc_start_main
#9 Object "furnace", at 0x5604fb8d1cc8, in main
#8 Object "furnace", at 0x5604fbacf650, in FurnaceGUI::loop()
#7 Object "furnace", at 0x5604fba3238a, in FurnaceGUI::drawInsEdit()
#6 Object "furnace", at 0x5604fb99c468, in ImGui::InputText(char const*, std::__cxx11::basic_string<char, std::char_traits, std::allocator >, int, int ()(ImGuiInputTextCallbackData*), void*)
#5 Object "furnace", at 0x5604fb974fec, in ImGui::InputText(char const*, char*, unsigned long, int, int ()(ImGuiInputTextCallbackData), void*)
#4 Object "furnace", at 0x5604fb97b699, in ImGui::InputTextEx(char const*, char const*, char*, int, ImVec2 const&, int, int ()(ImGuiInputTextCallbackData), void*)
#3 Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7f45bd858221, in __assert_fail
#2 Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7f45bd84942e, in
#1 Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7f45bd849545, in abort
#0 Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7f45bd85f8a1, in gsignal
Aborted (Signal sent by tkill() 26422 1000)

@freq-mod freq-mod added bug Something isn't working critical Requires urgent fixing labels Jun 21, 2022
@tildearrow tildearrow self-assigned this Jun 23, 2022
@tildearrow tildearrow added the done issue resolved label Jun 23, 2022
@tildearrow
Copy link
Owner

Applied a possible fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical Requires urgent fixing done issue resolved
Projects
None yet
Development

No branches or pull requests

2 participants