Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly libtiledb builds have been failing for over a month #7

Closed
jdblischak opened this issue Jun 16, 2023 · 4 comments
Closed

Nightly libtiledb builds have been failing for over a month #7

jdblischak opened this issue Jun 16, 2023 · 4 comments

Comments

@jdblischak
Copy link
Collaborator

I noticed today that the libtiledb nightlies builds have been broken for over a month (feedstock build logs for branch nightly-build). The oldest build log is for May 17. The error message is:

-- Found AWS lib: aws-cpp-sdk-identity-management ($SRC_DIR/build/externals/install/lib64/libaws-cpp-sdk-identity-management.a)
-- The TileDB library is compiled with Azure support.
CMake Error at tiledb/CMakeLists.txt:529 (find_package):
  Could not find a package configuration file provided by
  "azure-storage-blobs-cpp" with any of the following names:

    azure-storage-blobs-cppConfig.cmake
    azure-storage-blobs-cpp-config.cmake

  Add the installation prefix of "azure-storage-blobs-cpp" to
  CMAKE_PREFIX_PATH or set "azure-storage-blobs-cpp_DIR" to a directory
  containing one of the above files.  If "azure-storage-blobs-cpp" provides a
  separate development package or SDK, be sure it has been installed.


-- Configuring incomplete, errors occurred!

Thus I think the problem is related to the recently added support for the new Azure SDK for C++, which was merged on April 23rd

https://github.com/search?q=repo%3ATileDB-Inc%2FTileDB+azure-storage-blobs-cpp&type=code
TileDB-Inc/TileDB#3910
TileDB-Inc/TileDB@969dd1c

But has not yet been included in a release

https://github.com/TileDB-Inc/TileDB/releases
https://github.com/conda-forge/tiledb-feedstock/pulls?q=is%3Apr+is%3Aclosed

Is this simply a new dependency we will need to add to the conda recipe dependencies? I see that conda-forge provides azure-storage-blob

cc: @ihnorton, @Shelnutt2

@jdblischak
Copy link
Collaborator Author

I investigated some more. The conda-forge pacakge azure-storage-blob isn't helpful because it is a binary for the Python package on PyPI. Instead we need the C++ library azure-storage-blobs-cpp from the Azure SDK for C++. I don't believe any of these are available from conda-forge

@jdblischak
Copy link
Collaborator Author

Also, the nightly build is continuing to fail with the same CMake error after merging PR TileDB-Inc/TileDB#4058 in commit TileDB-Inc/TileDB@7be70ca

@jdblischak
Copy link
Collaborator Author

Another update: I disabled Azure support on Linux and macOS (-DTILEDB_AZURE=OFF), and then the nightly libtiledb built fine, so this is means that once the Azure dependency is resolved, the nightly builds should be passing again.

@jdblischak
Copy link
Collaborator Author

Closing this Issue. Last night's nightly libtiledb build was successful

  • Support for auto-installing the Azure SDK C++ libraries during the conda build has been available for weeks
  • Rotating the Azure variable BINSTAR_TOKEN for TileDB-Inc/tiledb-feedstock fixed the failing uploads
  • The Azure SDK C++ libraries have been added to conda-forge (azure-sdk-for-cpp: core, identity, storage conda-forge/staged-recipes#23297). Once they have been built for all the platforms and variants required by the tiledb-feedstock recipe, we will update its recipe to use the conda binaries instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant