Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: New natural_* landuse need custom sort_key #1096

Closed
2 tasks done
nvkelso opened this issue Oct 3, 2016 · 1 comment
Closed
2 tasks done

BUG: New natural_* landuse need custom sort_key #1096

nvkelso opened this issue Oct 3, 2016 · 1 comment

Comments

@nvkelso
Copy link
Member

nvkelso commented Oct 3, 2016

In #980 we added a few more kind values to differentiate from the landuse tags with the same values:

  • natural_wood
  • natural_forest
  • natural_park

We also need to add those new kind values to the documentation, and they're getting default sort_rank values right now (so they z-stack below every other landuse incorrectly).

  • Update layer docs
  • Update sort_rank CSVs

The other "natural" features are here:

wetland,*,35
scrub,*,34
meadow,*,33
grass,*,32

So we need to add the 3 new ones, and offset the rest up (including ALL the rest, not just these 4):

wetland,*,38
scrub,*,37
meadow,*,36
grass,*,35
natural_wood,34
natural_forest,33
natural_park,32

/cc @bcamper, thanks for finding the bug!

@nvkelso nvkelso added this to the v1.1.0 milestone Oct 3, 2016
@nvkelso nvkelso changed the title New natural_* landuse need custom sort_key BUG: New natural_* landuse need custom sort_key Oct 3, 2016
@nvkelso nvkelso added the bug label Oct 3, 2016
@nvkelso nvkelso added the ready label Oct 14, 2016
@nvkelso nvkelso added nextnext and removed ready labels Dec 15, 2016
@nvkelso nvkelso added ready and removed nextnext labels Apr 7, 2017
@nvkelso nvkelso modified the milestones: v1.1.0, v1.2.0 Apr 25, 2017
@nvkelso nvkelso modified the milestones: v1.5.0, v1.6.0 Jun 14, 2018
@ghost ghost assigned zerebubuth Dec 6, 2018
@ghost ghost added in review and removed ready labels Dec 6, 2018
@nvkelso
Copy link
Member Author

nvkelso commented Dec 21, 2018

Verified.

@nvkelso nvkelso closed this as completed Dec 21, 2018
@ghost ghost removed the in review label Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants