Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove early ferry and aeroway properties #2017

Closed
nvkelso opened this issue Dec 2, 2021 · 3 comments
Closed

Remove early ferry and aeroway properties #2017

nvkelso opened this issue Dec 2, 2021 · 3 comments
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Dec 2, 2021

At zoom 10 even after #2008 I still see a lot of individual ferry lines because we're not dropping shield_text and shield_text_length, and network.

This new logic needs to add a (kind == 'ferry' and zoom < 14) or clause, like:

  - fn: vectordatasource.transform.drop_properties
    params:
      source_layer: roads
      start_zoom: 0
      end_zoom: 15
      properties:
        - network
        - shield_text
        - shield_text_length
      where: >-
        (kind_detail == 'motorway' and zoom <  7) or
        (kind_detail == 'trunk' and zoom <  9) or
        (kind_detail == 'primary' and zoom <  11) or
        (kind_detail == 'secondary' and zoom <  12) or
        (kind_detail == 'tertiary' and zoom <  13) or
        (kind_detail == 'motorway_link' and zoom <  13) or
        (kind_detail == 'trunk_link' and zoom <  13) or
        (kind_detail == 'primary_link' and zoom <  14) or
        (kind_detail == 'secondary_link' and zoom <  14) or
        (kind_detail == 'tertiary_link' and zoom <  14) or
        (kind == 'minor_road' and zoom < 15) or
        (kind == 'path' and zoom < 14) or
        (kind == 'ferry' and zoom < 14) or
        (kind == 'rail' and zoom < 15)

For aeroway I see too many individual ways at zooms 8-13.

It's a few places like:

  - fn: vectordatasource.transform.drop_properties
    params:
      source_layer: roads
      start_zoom: 0
      end_zoom: 15
      # short-hand for "name" property in the list below means all name-like
      # properties.
      all_name_variants: true
      properties:
        - name
        - ref
        - all_networks
        - all_shield_texts
        - service
        - access
        - osm_relation
      where: >-
        (kind == 'highway' and zoom <  11) or    
        (kind_detail == 'trunk' and zoom <  12) or
        (kind_detail == 'primary' and zoom <  13) or
        (kind_detail == 'secondary' and zoom <  14) or
        (kind_detail == 'tertiary' and zoom <  14) or
        (kind_detail == 'motorway_link' and zoom <  14) or
        (kind_detail == 'trunk_link' and zoom <  14) or
        (kind_detail == 'primary_link' and zoom <  15) or
        (kind_detail == 'secondary_link' and zoom <  15) or
        (kind_detail == 'tertiary_link' and zoom <  15) or
        (kind == 'minor_road' and zoom < 15) or
        (kind == 'aeroway' and zoom < 14) or
        (kind == 'path' and zoom < 14) or
        (kind == 'rail' and zoom < 15) or
        (kind == 'ferry' and zoom < 15)
# drop these "detail" tags to get better merging at zoom < 14
  - fn: vectordatasource.transform.drop_properties
    params:
      source_layer: roads
      start_zoom: 0
      end_zoom: 14
      properties:
        - surface
      where: >-
        kind == 'minor_road' or 
        (kind == 'aeroway' and zoom < 12) or
        (kind == 'path' and zoom < 13)
- fn: vectordatasource.transform.drop_properties
    params:
      source_layer: roads
      start_zoom: 8
      end_zoom: 15
      properties:
        - landuse_kind
      where: >-
        (kind_detail == 'trunk' and zoom < 11) or
        (kind_detail == 'primary' and zoom < 12) or
        (kind_detail == 'secondary' and zoom < 13) or
        (kind_detail == 'tertiary' and zoom < 13) or
        (kind_detail == 'motorway_link' and zoom < 14) or
        (kind_detail == 'trunk_link' and zoom < 14) or
        (kind_detail == 'primary_link' and zoom < 15) or
        (kind_detail == 'secondary_link' and zoom < 15) or
        (kind_detail == 'tertiary_link' and zoom < 15) or
        (kind == 'minor_road' and zoom < 15) or
        (kind == 'aeroway' and zoom < 13) or
        (kind == 'path' and zoom < 14) or
        (kind == 'rail' and zoom < 14)
@nvkelso nvkelso added this to the v1.9.0 milestone Dec 2, 2021
@nvkelso nvkelso changed the title Remove early ferry properties Remove early ferry and aeroway properties Dec 2, 2021
@peitili
Copy link
Contributor

peitili commented Dec 6, 2021

@nvkelso would you also add the operator change and also a specific tile to verify after the change here?

@nvkelso
Copy link
Member Author

nvkelso commented Dec 7, 2021

@nvkelso would you also add the operator change

596c85f

also a specific tile to verify after the change here?

These two 512 px sized tiles for the ferry changes:

  • 10/511/340 has 63 ferry lines now... but should just have 3 or 5 after (one per unique min_zoom value), though colour may come into play, there are 5 values there now.
  • 12/2046/1362 has 58 ferry lines now... but should have 4 to 5 after, same deal

For the aeroway changes, this 512 px sized tile:

  • 8/127/85 has 82 lines now, but should just have a couple (based if it's an international airport or not)

@peitili peitili self-assigned this Dec 9, 2021
@nvkelso
Copy link
Member Author

nvkelso commented Dec 15, 2021

Fixed via #2030.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants