Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove names from short road segments #2019

Closed
nvkelso opened this issue Dec 2, 2021 · 2 comments
Closed

Remove names from short road segments #2019

nvkelso opened this issue Dec 2, 2021 · 2 comments
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Dec 2, 2021

In #2008 we stripped names from roads per kind of road and zoom. But that still yields names on short road segments which don't have enough room to actually label.

After roads are merged, we should evaluate if the merged features are long enough to have the name actually label, and if it's not long enough drop the names.

Then we should merge features again so the newly nameless roads merge together.

We do this same trick in the boundaries layer already, so reprise that here:

@nvkelso nvkelso added this to the v1.9.0 milestone Dec 2, 2021
@nvkelso
Copy link
Member Author

nvkelso commented Dec 2, 2021

Additionally we should evaluate dropping features with very short length during the new merge, similar to:

Where we use different drop_length_pixels config for:

drop_short_segments: true
drop_length_pixels: 0.1

@nvkelso
Copy link
Member Author

nvkelso commented Dec 15, 2021

Fixed via #2031.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants