Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in Type entry of .desktop files #365

Closed
Evpok opened this issue Aug 3, 2017 · 5 comments
Closed

Typo in Type entry of .desktop files #365

Evpok opened this issue Aug 3, 2017 · 5 comments
Labels
type: bug Something is not working as expected or the documentation is incorrect.
Projects
Maintenance
Milestone
4.7

Comments

@Evpok
Copy link

Evpok commented Aug 3, 2017 •
edited

TL;DR

kbuildsycoca5 reports issues with nuvolapps .desktop files : their Type entry is " Application" instead of "Application"

Steps to reproduce

  • Run kbuildsycoca5
  • Get this output
$ kbuildsycoca5
kbuildsycoca5 running...
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppGroove.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppGroove.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppYandexMusic.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppYandexMusic.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppGooglePlayMusic.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppGooglePlayMusic.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppYoutube.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppYoutube.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppMixcloud.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppMixcloud.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppTunein.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppTunein.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppLogitechMediaServer.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppLogitechMediaServer.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppAmazonCloudPlayer.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppAmazonCloudPlayer.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaApp8tracks.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaApp8tracks.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppDeezer.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppDeezer.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppSiriusxm.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppSiriusxm.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppJango.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppJango.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppSpotify.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppSpotify.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppBandcamp.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppBandcamp.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppKexp.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppKexp.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppSoundcloud.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppSoundcloud.desktop"
The desktop entry file  "/usr/share/applications/eu.tiliado.NuvolaAppPlex.desktop"  has Type= " Application"  instead of "Application" or "Service"
kf5.kservice.sycoca: Invalid Service :  "/usr/share/applications/eu.tiliado.NuvolaAppPlex.desktop"

Version

$ nuvolaplayer3 --version
Nuvola Player 3 3.0.9
Revision f79856a684ab9fbce31d814059a4fc20a51489c1
WebKitGTK 2.16.6
libsoup 2.56.0
@jiri-janousek
Copy link
Member

Hello @Evpok. Thanks for reporting this issue. I'll remove the spaces around the equal sign but kbuildsycoca5 should be fixed to ignore them instead of failing.

Space before and after the equals sign should be ignored; the = sign is the actual delimiter.
-- https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s02.html

@jiri-janousek jiri-janousek added the type: bug Something is not working as expected or the documentation is incorrect. label Aug 3, 2017
@jiri-janousek jiri-janousek added this to the August 2017 milestone Aug 3, 2017
@Evpok
Copy link
Author

Evpok commented Aug 3, 2017

indeed, reporting this issue to KDE. Thanks for pointing it out.

@cfeck
Copy link

cfeck commented Aug 3, 2017

See https://bugs.kde.org/show_bug.cgi?id=310674

@jiri-janousek jiri-janousek added this to Backlog in Maintenance Aug 5, 2017
jiri-janousek added a commit to tiliado/nuvolasdk that referenced this issue Aug 5, 2017
@jiri-janousek
desktop launcher: remove spaces around =
3b42a28 
Although they are valid, they confuse kbuildsycoca5.

- Issue: tiliado/nuvolaplayer#365
- Upstream ticket: https://bugs.kde.org/show_bug.cgi?id=310674

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@jiri-janousek
Copy link
Member

Fixed in tiliado/nuvolasdk master. I'll rebuild packages later.

@jiri-janousek jiri-janousek moved this from Backlog to In progress in Maintenance Aug 5, 2017
@jiri-janousek
Copy link
Member

It should be now fixed in packages for Nuvola 3. Updated packages for Nuvola 4 are being built right now.

@jiri-janousek jiri-janousek modified the milestones: 4.7, August 2017 Aug 6, 2017
@jiri-janousek jiri-janousek moved this from In progress to To Release in Maintenance Aug 6, 2017
jiri-janousek added a commit to tiliado/nuvolasdk that referenced this issue Sep 2, 2017
@jiri-janousek
Release 4.7.0 - September 1st, 2017
bf09583 
  * desktop launcher: Spaces around the equals sign were removed because
    they confuse kbuildsycoca5. Issue: tiliado/nuvolaplayer#365
    Upstream ticket: https://bugs.kde.org/show_bug.cgi?id=310674
  * Added individual version info properties
   `nuvolasdk.VERSION_MAJOR/MINOR/MICRO`.
  * new-project: New `metadata.in.json` files use the latest Nuvola SDK
    version.

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@jiri-janousek jiri-janousek moved this from To Release to Done in Maintenance Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something is not working as expected or the documentation is incorrect.
Projects
No open projects
Maintenance
Done
Milestone
4.7
Development

No branches or pull requests
3 participants
@jiri-janousek @Evpok @cfeck