New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to Chromium Embedded Framework #372
Comments
CEF is not compatible with GTK+ 3.22: cztomczak/cefcapi#9 |
Neither compatible: 3.20.9-1ubuntu2.1 (Ubuntu 16.10), 3.18.9-1ubuntu3.3 (Ubuntu 16.04). |
|
|
The first failing commit between 3.15.1 and 3.15.2 is GNOME/gtk@dae447728d |
This works: GtkWidget* create_gtk_window(char* title, int width, int height) {
printf("create_gtk_window\n");
// Create window.
GtkWidget* window = gtk_window_new(GTK_WINDOW_TOPLEVEL);
...
// GTK+ > 3.15.1 uses an X11 visual optimized for GTK+'s OpenGL stuff
// since revid dae447728d: https://github.com/GNOME/gtk/commit/dae447728d
// However, it breaks CEF: https://github.com/cztomczak/cefcapi/issues/9
// Let's use the default X11 visual instead the GTK's blessed one.
GdkScreen* screen = gdk_screen_get_default();
GList* visuals = gdk_screen_list_visuals(screen);
printf("n visuals: %u\n", g_list_length(visuals));
GdkX11Screen* x11_screen = GDK_X11_SCREEN(screen);
g_assert(x11_screen != NULL);
Visual* default_xvisual = DefaultVisual(GDK_SCREEN_XDISPLAY(x11_screen),
GDK_SCREEN_XNUMBER(x11_screen));
GdkVisual* default_visual = NULL;
int i = 0;
while (visuals != NULL) {
GdkVisual* visual = GDK_X11_VISUAL (visuals->data);
if (default_xvisual->visualid == gdk_x11_visual_get_xvisual(
GDK_X11_VISUAL (visuals->data))->visualid) {
printf("Default visual %d\n", i);
default_visual = visual;
}
i++;
visuals = visuals->next;
}
gtk_widget_set_visual(GTK_WIDGET(window), default_visual);
gtk_widget_show_all(window);
return vbox;
} |
https://github.com/tiliado/valacef Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Set environment variable NUVOLA_USE_CEF=true to enable it. Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Set environment variable NUVOLA_USE_CEF=true to enable it. Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Not to forget. Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
- Issue: tiliado/nuvolaplayer#374 - Issue: tiliado/nuvolaplayer#372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
- Issue: tiliado/nuvolaplayer#374 - Issue: tiliado/nuvolaplayer#372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
To preserve script line number Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Blog post: Status of Chromium-based Port of Nuvola |
New issue: Poor performance with NVidia GTX 1070 (driver 387.34) - see tiliado/valacef#1 |
- It is the first one that satisfies requirements - Default engine is WebKitGTK+ unless --cef-default build flag is used. - Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Thanks @bartlibert. I cannot reproduce the issue on my machine. It might disappear after I solve tiliado/valacef#1. Can you reproduce the issue also with Cefium demo browser?
|
This allows CefEngine to use CEF main loop to achieve high performance. Issue: tiliado/valacef#1 Issue: #372 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Hi, I tried testing it with Cefium and got:
Soo... this pointed me to try everything in X11 instead of Wayland and guess what: there it works. |
Thanks, @bartlibert. Could you test again under Wayland with Cefium which comes with Nuvola 4.9.93? |
I don't get the "invalid cast" error anymore and get into google music, but the popup menus are still not working. (No errors in terminal nor web console) |
I don't know if this is where I should post this, or if I should create a new issue (clicking report bug took me here instead of the general 'issues' page) But here's my bug report: OS - Linux Mint 18.3 Not sure if this matters but I also have the official spotify app installed through their flatpak as well, 'flatpak list' returns: |
Hello @TrevorScheitrum. Thanks for reporting your issue. Could you create a new ticket for that with debug logs from Nuvola 4.9.163? |
Since posting this report it hasn't crashed, so i'm wondering if my system was low on ram or something. If it starts crashing again I'll try to grab debug logs and open a new issue ticket. |
Closing in favor of #424. |
Primary Targets
Unresolved Issues
Background playback: Nuvola quits when the window is closed.Fixed in Nuvola 4.9.50.Proxy settings: It is grabbed from the system and cannot be changed yet.Clipboard: CEF cannot paste text from the system clipboard unless external message pump is disabled, but CPU usage is higher then Paste doesn't work outside web view valacef#2Missing support forweb_app.allow_insecure_content
- it is used by only a single script.Password manager does not work and may crash.→ Add password manager integrated with system keyring #418Request filtering is not implemented.Scripts depending on deprecated synchronous API calls need to be ported:Nuvola._keyValueStorageSetDefaultValue
Poor performance with NVidia GTX 1070 (driver 387.34)- see Performance issues valacef#1Testing
The text was updated successfully, but these errors were encountered: