fix(Dropdown): put empty array to filtered items when searchable is f…

…alse (#628)
tillersystems · Jul 9, 2019 · 2708d77 · 2708d77
1 parent 9de45f0
commit 2708d77
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/Dropdown/index.js b/src/Dropdown/index.js
@@ -161,9 +161,11 @@ class Dropdown extends PureComponent {
     // Filter items based on search key word
     // TODO: when need to refactor this later, children may have some children
     // we need to filter recursively. - @Thomas -
-    const FiltredItem = Children.toArray(children).filter(({ props: { children } }) =>
-      children.toLowerCase().includes(searchKeyword.toLowerCase()),
-    );
+    const FilteredItems = searchable
+      ? Children.toArray(children).filter(({ props: { children } }) =>
+          children.toLowerCase().includes(searchKeyword.toLowerCase()),
+        )
+      : [];
 
     return (
       <div className={className} data-testid="dropdown">
@@ -196,8 +198,8 @@ class Dropdown extends PureComponent {
                 )}
 
                 {searchable &&
-                  (FiltredItem.length !== 0
-                    ? FiltredItem.map(child => (
+                  (FilteredItems.length !== 0
+                    ? FilteredItems.map(child => (
                         <MenuItem key={child.key} searchable={searchable} role="menuitem">
                           {child}
                         </MenuItem>