fix(Input): fix placeholder style #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sun-tea
force-pushed
the
fix-placeholder
branch
from
1704b27
to
ebcf187
Compare
sun-tea
force-pushed
the
fix-placeholder
branch
from
ebcf187
to
e6b4d15
Compare
spartDev
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief
Use placeholder pseudo-element instead of deprecated method from polished lib.
Description
Polished dependency deprecated its
placeholder()method, so we need to remove it from our lib.Stardust is broken because of that in captain-client (weirdly it broke on update of polished dependency in captain-client, I would have thought that inner dependency in Stardust would not be impacted?). Either way this PR is fixing it.
Requirements :
yarncommand.Todo - Checklist: