Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Table): Change hover cell to hover row #840

Merged
merged 5 commits into from
Oct 28, 2019
Merged

fix(Table): Change hover cell to hover row #840

merged 5 commits into from
Oct 28, 2019

Conversation

Artikodin
Copy link
Contributor

@Artikodin Artikodin commented Oct 24, 2019 •
edited
Loading

  • Feature
  • Fix
  • Enhancement

Description

Quick fix to change the hoverable element. I change this behaviour to be optional with the props isHoverable. Tests done 馃憤

Todo - Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.

@Artikodin Artikodin requested a review from anglol October 24, 2019 14:42
@Artikodin Artikodin added enhancement Enhancement or refactoring of existing feature need review labels Oct 24, 2019
anglol
anglol previously requested changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@anglol anglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it an option ;)

@anglol anglol removed their assignment Oct 24, 2019
@Artikodin Artikodin changed the title fix(SalesTable): Change hover cell to hover row fix(Table): Change hover cell to hover row Oct 25, 2019
@Artikodin Artikodin requested a review from anglol October 25, 2019 08:36
sun-tea
sun-tea suggested changes Oct 25, 2019
View reviewed changes
src/Table/__tests__/Table.test.js Outdated Show resolved Hide resolved
sun-tea
sun-tea previously approved these changes Oct 25, 2019
View reviewed changes
@sun-tea sun-tea removed their assignment Oct 25, 2019
@sun-tea sun-tea dismissed anglol鈥檚 stale review October 28, 2019 09:26

Changes addressed

@sun-tea sun-tea merged commit 752ecf4 into master Oct 28, 2019
@sun-tea sun-tea deleted the fix/table_hover branch December 9, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sun-tea sun-tea sun-tea approved these changes

@spartDev spartDev Awaiting requested review from spartDev

@anglol anglol Awaiting requested review from anglol

Assignees

@spartDev spartDev

@anglol anglol

Labels
enhancement Enhancement or refactoring of existing feature need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Artikodin @anglol @sun-tea @spartDev