Fix bug in Alfred 4 using getenv() #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jamesbellnet. It's working fine for me, what OS are you running? |
`getenv('alfred_theme_subtext') ?? '0'` would be ideal, but let's KISS
|
Hi @tillkruss, I'm running Catalina 10.15.4. I also upgraded my local install of PHP today via Homebrew to PHP 7.4.5 (cli). |
|
Thanks! I released a new version. Let me know if that works. |
|
Yes just downloaded and tested and it all works fine! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing a fresh install of Alfred 4 then downloading this workflow today it wasn't working correctly - the
ldkeyword was fine but any query would cause Alfred to default to performing a web search.After using the debugging tool in Alfred I could see the following:
PHP Notice: Undefined index: branch in [...]/laravel.php on line 18I also noticed the URL for the Laravel documentation was missing the branch variable in the JSON response.
After a quick search I came across this and this in the Alfred forums, stating in PHP we should use
getenv()over$_ENV. After updating the code I found it is working perfectly in Alfred 4.