Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel version switch parameter #7

Merged
merged 5 commits into from Aug 3, 2018
Merged

Add Laravel version switch parameter #7

merged 5 commits into from Aug 3, 2018

Conversation

jakebathman
Copy link
Contributor

I've already used this so many times in the last few days, thanks for publishing it.

Overview

This PR adds an optional version switch in the command. If not included, the branch will fall back to the $_ENV value (defaults to master as before). This is a stripped down version of PR #3 since you're a rockstar who had already done half of the stuff 🥇

Example to search docs for Laravel 5.1:

monosnap 2018-07-31 10-09-12

@tillkruss
Copy link
Owner

Thanks man! Do the changes I made make sense to you?

@ryanw3b3r
Copy link

Sorry, I might misread it @tillkruss, but I don't think that if (trim($matches[1]) != "") (trimmed string is not empty) is the same as if (empty(trim($matches[1]))) (empty trimmed string) Looks like you need ! before empty?

@jakebathman
Copy link
Contributor Author

Yeah you'll definitely need ! empty() to make that work.

Also, embarrassed to say I didn't know about \h before 🤷‍♂️

Otherwise, looks great to me.

@tillkruss
Copy link
Owner

Yes, of course @ryanw3b3r. Thanks!

LGTM. We could really use a test suite now I guess.

@tillkruss tillkruss merged commit e38709e into tillkruss:master Aug 3, 2018
@jakebathman jakebathman deleted the add-version-switch-param branch September 17, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants