-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve trigger_mode=TRIGGER_MODE_MANUAL #2211
Comments
Thanks! Can you share a bit more detail on what you want to restart the pod? Like did it have a temporary error that you want to retry? Or did it start too early before another service was up? Or something else? We've had similar "restart a thing" requests a few times, and it's been surprisingly tough because different use-cases need slightly different semantics (see #1928 and #2068) cc @hyu who has been collecting examples of use-cases |
Just look at the interface: The first intent after this setup was to click on it. And nothing happens :) And in the dev process there are the cases when you need to restart only 1 service, which is on hot-reload by default with out container rebuilding (for languages like Python or Ruby or NodeJS, etc). You are do not always use livenessProbe for the development, so now it may require too much hassle, while interfase is done already. |
That all makes sense! And it seems like you have two different threads here:
|
I second this ticket. I have specified one of our services as "manual reload", since it would be non-trivial for it to detect when it needs to be automatically reloaded. Sure enough, the UI shows (what looks like) a reload button: However, nothing happens when it's clicked. How's the manual restart supposed to be triggered then? |
@sssilver yeah that's a very fair point -- the idea behind manual trigger as it currently stands is that Tilt detects file changes that correspond to your service, but doesn't DO anything with them until you click "go". There's still no way to just trigger a build unless one of the associated files has changed. I totally agree that a. this should be a feature, and that b. the UI here is misleading. |
Hey folks, exciting news! We've just launched a "Force Update" feature! Take a look at our feature announcement and let us know if this meets your needs :) |
Thank you, @maiamcc ! You r awesome! |
Feature request
Now
does not allow to restart the service, even when I have this button in the interface. But why not just re-issue the pod on the button press? It looks like native behaviour.
The text was updated successfully, but these errors were encountered: