Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local resources with invalid readiness probe specs cause dependent resources to never start #4156

Closed
milas opened this issue Feb 4, 2021 · 0 comments · Fixed by #4158
Closed
Labels
bug Something isn't working

Comments

@milas
Copy link
Contributor

milas commented Feb 4, 2021

Expected Behavior

  • Resource should not start itself and show an error state

Current Behavior

  • Resource starts and will show as ready but dependent resources will never start

Steps to Reproduce

  1. Create a local_resource with a bad probe spec (do not include exec / http_get / tcp_socket so that there's no action, e.g. readiness_probe=probe())
  2. Create a local_resource dependent upon the former
  3. Run tilt up

Additional Context

  • Realistically, we won't be able to do all validation during Tiltfile parsing, so we'll always need to handle this case on resource start when the actual probe worker is initialized
  • Currently, the logic attempts to log a warning and fallback to process being immediately ready; unfortunately, other state logic will still see a probe spec as existing and so things get into a weird, inconsistent state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant