Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local_resource will not accept explicit None for readiness_probe value #4160

Closed
milas opened this issue Feb 4, 2021 · 0 comments · Fixed by #4163
Closed

local_resource will not accept explicit None for readiness_probe value #4160

milas opened this issue Feb 4, 2021 · 0 comments · Fixed by #4163
Labels
bug Something isn't working

Comments

@milas
Copy link
Contributor

milas commented Feb 4, 2021

Expected Behavior

local_resource('foo', serve_cmd='./myserver', readiness_probe=None) should behave the same as if the kwarg was omitted

Current Behavior

local_resource('foo', serve_cmd='./myserver', readiness_probe=None) results in an error:

Error: local_resource: for parameter "readiness_probe": got NoneType, want struct

This makes the ergonomics awkward when dynamically generating a resource that may or may not have a probe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant