Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Build Utility Doesn't Have --add-host Option #6139

Closed
oguzhanuninsider opened this issue Jun 9, 2023 · 3 comments · Fixed by #6185
Closed

Docker Build Utility Doesn't Have --add-host Option #6139

oguzhanuninsider opened this issue Jun 9, 2023 · 3 comments · Fixed by #6185
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@oguzhanuninsider
Copy link

Describe the Feature You Want

I want the docker build command's --add-host option to be applicable

Current Behavior

According to this link there is no such option.

Why Do You Want This?

Because there are some software packages that I pull from a private registry.

Additional context
Add any other context or screenshots about the feature request here.

@oguzhanuninsider oguzhanuninsider added the enhancement New feature or request label Jun 9, 2023
@nicks
Copy link
Member

nicks commented Jun 9, 2023

thanks! shouldn't be too hard to add if you want to put together a PR. you basically need to wire a docker_build argument up to ImageBuildOptions's ExtraHosts (https://pkg.go.dev/github.com/docker/docker/api/types#ImageBuildOptions)

Here's an example PR:
#4934

@nicks nicks added the good first issue Good for newcomers label Jul 20, 2023
@Azanul
Copy link
Contributor

Azanul commented Jul 28, 2023

May I resolve this?

@smaaland
Copy link

Nice addition 👍 Would be nice to have it reflected in the documentation as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants