ffi: delegate all allocations to the caller #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As in this design both ulid_new_string() and ulid_write_new() would be identical, the latter is dropped. Due to the increased number of tests, a problem with rand() not being reentrant became a lot more apparent. The tests can be made to work reliably with `--test-threads 1`, but a proper solution is still needed, as that is a bug that affects normal use of the public APIs. Most of the tests can also be executed in Miri with: MIRIFLAGS="-Zmiri-disable-isolation" cargo +nightly miri test (-Zmiri-disable-isolation is required for SystemTime::new()).
|
Thanks very much for this contribution @jonasmalacofilho. I have logged issue #8 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to our email conversation.
As in this design both
ulid_new_string()andulid_write_new()would be identical, the latter is dropped.Due to the increased number of tests, a problem with
rand()not being reentrant became a lot more apparent. The tests can be made to work reliably with--test-threads 1, but a proper solution is still needed, as that is a bug that affects normal use of the public APIs.Most of the tests can also be executed in Miri with:
(
-Zmiri-disable-isolationis required forSystemTime::new()).