Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonApiServerImplementation 'final'`, doesn't allow custom implementations #32

Open
GeoSot opened this issue Jun 7, 2023 · 2 comments

Comments

@GeoSot
Copy link

GeoSot commented Jun 7, 2023

JsonApiServerImplementation class is a simple DTO that keeps jsonapi server information.
There are cases, where some schemas need to declare some profiles etc. Unfortunately, the usage of final keyword, prevents any extension in order to support profile & extension properties.
It would be fine to either remove the final keyword, or support the extra properties JSON:API defines

final class JsonApiServerImplementation implements JsonSerializable

@GeoSot GeoSot changed the title JsonApiServerImplementation 'final'`, doesnm't allow custom implementations JsonApiServerImplementation 'final'`, doesn't allow custom implementations Jun 7, 2023
@GeoSot
Copy link
Author

GeoSot commented Jun 12, 2023

@timacdonald Can you help fixing this or propose a way in order to open a PR?
Any help will be appreciated

@timacdonald
Copy link
Owner

I would say that we should add support for those properties on the JsonApiServerImplementation class the package ships with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants