New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bodyclose fails unexpected #49

Closed

zirain opened this issue Apr 26, 2023 · 1 comment

zirain commented Apr 26, 2023

bodyclose will fails with following code:

        resp, err := client.Do(req)
	if err != nil {
		return
	}
	// lint will fail
	defer func(b io.ReadCloser) {
		_ = b.Close()
	}(resp.Body)

but it's ok with:

        resp, err := client.Do(req)
	if err != nil {
		return
	}
	// lint will fail
	 defer resp.Body.Close()

zirain mentioned this issue

Bump k8s.io to v0.27.1 kubernetes-sigs/gateway-api#1956

Merged

Author

zirain commented May 6, 2023 •

edited

should change code to:

        resp, err := client.Do(req)
	if err != nil {
		return
	}
	defer func(b io.Closer) {
		_ = b.Close()
	}(resp.Body)

zirain closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment