Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NODE_PATH incompatible with rewired tests #49

Closed
alex-pex opened this issue Jun 24, 2017 · 2 comments
Closed

NODE_PATH incompatible with rewired tests #49

alex-pex opened this issue Jun 24, 2017 · 2 comments

Comments

@alex-pex
Copy link

I use the NODE_PATH env var to add an additional node module directory. With regular react-scripts there's no problem but it crashes with rewired tests.

I set up a mini-project to show the issue. You can run npm run start or npm run start:rewired and it works fine, npm run test too but npm run start:rewired shows Cannot find module 'package.json'

Here is the link to my repository : https://github.com/alex-pex/react-app-rewired-sample

@alex-pex
Copy link
Author

Maybe you need to merge this patch : facebook/create-react-app@d24311e

@timarney
Copy link
Owner

Thanks for setting up the mini-project that will be helpful to track down the issue.

Hoping to find some time in July to bring this repo back closer to the lastest React Scripts

Yes - looks like things are getting out of sync

https://github.com/timarney/react-app-rewired/blob/master/packages/react-app-rewired/config/paths.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants