Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.22 updates Twig to 3.4.3 #2672

Closed
Levdbas opened this issue Nov 8, 2022 · 3 comments
Closed

1.22 updates Twig to 3.4.3 #2672

Levdbas opened this issue Nov 8, 2022 · 3 comments

Comments

@Levdbas
Copy link
Member

Levdbas commented Nov 8, 2022

Expected behavior

Updating to 1.22 should install twig to 2.15.3

Actual behavior

Updating to 1.22 updates twig to 3.4.3

This introduces breaking changes like a missing filter tag

First reported: #2658 (comment)

See https://getcomposer.org/doc/articles/versions.md#summary.

So this

"twig/twig": ">=1.44.7 || ^2.10",

afbeelding

Leads to the following packages: https://semver.madewithlove.com/?package=twig%2Ftwig&constraint=%3E%3D1.44.7+||+^2.10&stability=stable

Steps to reproduce behavior

composer create-project roots/bedrock .
composer require timber/timber

What version of WordPress, PHP and Timber are you using?

WordPress 6.1
PHP 8.0.22
Timber 1.22

How did you install Timber? (for example, from GitHub, Composer/Packagist, WP.org?)

Composer

@xavivars
Copy link
Contributor

Same thing is happening.

"twig/twig": ">=1.44.7 || ^2.10",
should be
"twig/twig": "^1.44.7 || ^2.10",

otherwise, twig 3 is installed (as it's > than 1.44.7)

@gchtr
Copy link
Member

gchtr commented Nov 22, 2022

Thanks for your insights and your help! And thanks for the link to the Semver checker, @Levdbas, that’s really helpful.

This will be fixed in #2679. I’ll see that we can publish a hotfix release for this as soon as possible.

@jarednova
Copy link
Member

Yep, in the midst of a deploy right now! Thanks to @Levdbas @xavivars and @gchtr for serving this all up on a silver platter for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants