Fix adding classes in MenuItem
#2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
requested review from
gchtr,
jarednova and
nlemoine
as code owners
Closed
nlemoine
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
N/A
Issue
In Timber V1
MenuItemwould have classes with their own ID e.g.menu-item-123.In Timber V2 this was missing.
Solution
Upon investigation I found that
add_classhad an inverted boolean check forin_array.Correcting this fixes the issue.
Impact
This changes improves backwards compat with V1.
Usage Changes
N/A
Considerations
N/A
Testing
I assume that tests are missing or incorrect for this feature because it is a boolean flip.
Might be best if someone increased coverage.