Fix PostIterator, if post is null

[rubas]

Related: #2917

Issue

$post can be null, which breaks the code.

[nlemoine]

Thank you @rubas for this PR.

We still support PHP 7.4 so $post?->setup(); syntax will not work. Can you adapt your PR to match 7.4 requirements?

[rubas]

protected null|Post $last_post;

The support for union type was only introduced in PHP 8.0.

[rubas]

The failed coding standard test is outside of this PR. I'm happy to push a fix...

1) tests/test-timber-cache.php

    ---------- begin diff ----------
@@ -329,7 +329,7 @@
         $clear = $loader->clear_cache_timber(Timber\Loader::CACHE_OBJECT);
         $this->assertTrue($clear);
         $works = true;
-      
+
         if (isset($wp_object_cache->cache[Timber\Loader::CACHEGROUP])
             && !empty($wp_object_cache->cache[Timber\Loader::CACHEGROUP])) {
             $works = false;
    ----------- end diff -----------


Applied checkers:

 * PhpCsFixer\Fixer\Whitespace\NoWhitespaceInBlankLineFixer

[Levdbas]

Thank you @rubas for taking this on. This might fix #2859 as well?

[nlemoine]

for coding standards, you just need to run composer run cs:fix. But you can leave the failing test file or fix it. We'll take care of it later.

[rubas]

Thank you @rubas for taking this on. This might fix #2859 as well?

Correct. This is the same bug.

[nlemoine]

Thanks @rubas. This is almost good for me.

Can you add the nullable type to $last_post and a test case for this?

[nlemoine]

This is all good, thanks @rubas!