Skip to content
This repository has been archived by the owner on Dec 8, 2020. It is now read-only.

Commit

Permalink
Round time_ms to a sane length
Browse files Browse the repository at this point in the history
  • Loading branch information
binarylogic committed Feb 19, 2017
1 parent 749604f commit ad59944
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lib/timber/events/http_server_response.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class HTTPResponse < Timber::Event

def initialize(attributes)
@status = attributes[:status] || raise(ArgumentError.new(":status is required"))
@time_ms = attributes[:time_ms] || raise(ArgumentError.new(":time_ms is required"))
@time_ms = attributes[:time_ms].round(6) || raise(ArgumentError.new(":time_ms is required"))
@additions = attributes[:additions]
end

Expand Down
2 changes: 1 addition & 1 deletion lib/timber/events/sql_query.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class SQLQuery < Timber::Event

def initialize(attributes)
@sql = attributes[:sql] || raise(ArgumentError.new(":sql is required"))
@time_ms = attributes[:time_ms] || raise(ArgumentError.new(":time_ms is required"))
@time_ms = attributes[:time_ms].round(6) || raise(ArgumentError.new(":time_ms is required"))
@message = attributes[:message] || raise(ArgumentError.new(":message is required"))
end

Expand Down
2 changes: 1 addition & 1 deletion lib/timber/events/template_render.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class TemplateRender < Timber::Event
def initialize(attributes)
@message = attributes[:message] || raise(ArgumentError.new(":message is required"))
@name = attributes[:name] || raise(ArgumentError.new(":name is required"))
@time_ms = attributes[:time_ms] || raise(ArgumentError.new(":time_ms is required"))
@time_ms = attributes[:time_ms].round(6) || raise(ArgumentError.new(":time_ms is required"))
end

def to_hash
Expand Down
2 changes: 1 addition & 1 deletion spec/timber/logger_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
message = Timber::Events::SQLQuery.new(sql: "select * from users", time_ms: 56, message: "select * from users")
logger.info(message)
expect(io.string).to start_with("select * from users @timber.io {\"level\":\"info\",\"dt\":\"2016-09-01T12:00:00.000000Z\",")
expect(io.string).to include("\"event\":{\"server_side_app\":{\"sql_query\":{\"sql\":\"select * from users\",\"time_ms\":56}}}")
expect(io.string).to include("\"event\":{\"server_side_app\":{\"sql_query\":{\"sql\":\"select * from users\",\"time_ms\":56.0}}}")
end

it "should allow functions" do
Expand Down

0 comments on commit ad59944

Please sign in to comment.