Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facing Error: preferences.getString(...).uppercase(Locale.ENGLISH) #473

Closed
devduttabain opened this issue Sep 15, 2022 · 0 comments
Closed

Comments

@devduttabain
Copy link

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

Today I used patch-package to patch cordova-plugin-lottie-splashscreen@0.9.6 for the project I'm working on.

Concerns

  • Installing this package (v0.9.6) from npm was not running properly (crashing the app), so I had to install it from git.
  • Then it was showing error while building/running in Android Studio
  • I have no prior knowledge of Kotlin/Android
  • New to Ionic
  • Using package in capacitor

Here is the diff that solved my problem:

diff --git a/node_modules/cordova-plugin-lottie-splashscreen/src/android/LottieSplashScreen.kt b/node_modules/cordova-plugin-lottie-splashscreen/src/android/LottieSplashScreen.kt
index 6fd73e0..c8400c0 100644
--- a/node_modules/cordova-plugin-lottie-splashscreen/src/android/LottieSplashScreen.kt
+++ b/node_modules/cordova-plugin-lottie-splashscreen/src/android/LottieSplashScreen.kt
@@ -211,7 +211,7 @@ class LottieSplashScreen : CordovaPlugin() {
             preferences.getString(
                 "LottieScaleType",
                 "FIT_CENTER"
-            ).uppercase(Locale.ENGLISH)
+            )//.uppercase(Locale.ENGLISH)
         )
 
         val color = ColorHelper.parseColor(

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants