Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates trunk_open to actuate_trunk #77

Merged
merged 2 commits into from Aug 5, 2018

Conversation

jonahwh
Copy link
Contributor

@jonahwh jonahwh commented Aug 5, 2018

This was a change in the Tesla API sometime around the end of July 2018

This was a change in the Tesla API sometime around the end of July 2018
@coveralls
Copy link

coveralls commented Aug 5, 2018

Coverage Status

Coverage decreased (-0.6%) to 81.065% when pulling 928d16f on jonahwh:fix-trunk-open into f346481 on timdorr:master.

@timdorr
Copy link
Owner

timdorr commented Aug 5, 2018

I'm not sure why the test suite passed, but this doesn't appear to be correct. Looking at the cassettes, Tesla's API is saying the command is invalid.

@jonasman
Copy link
Contributor

jonasman commented Aug 5, 2018

I just tried and this works, version 2018.26

@jonahwh
Copy link
Contributor Author

jonahwh commented Aug 5, 2018

@timdorr fixed up the tests

@timdorr
Copy link
Owner

timdorr commented Aug 5, 2018

Cool, thanks!

@timdorr timdorr merged commit 9b49a19 into timdorr:master Aug 5, 2018
@the-mace
Copy link

the-mace commented Sep 8, 2018

Current version on apiary doesn't show this change:
https://timdorr.docs.apiary.io/#reference/vehicle-commands/open-trunkfrunk/open-trunk/frunk

timdorr pushed a commit that referenced this pull request Nov 11, 2018
* Updates trunk_open to actuate_trunk

This was a change in the Tesla API sometime around the end of July 2018

* Updates open trunk/frunk tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants