Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rangy-highlighter partial un-highlight supported? #426

Open
abrekken opened this issue Aug 27, 2017 · 2 comments
Open

rangy-highlighter partial un-highlight supported? #426

abrekken opened this issue Aug 27, 2017 · 2 comments

Comments

@abrekken
Copy link

Unless I'm missing something, I don't see that this feature is supported in the rangy highlighter.

Example: select some text and call highlightSelection(). Then select a portion of the highlighted text and call unhighlightSelection(). What happens is it will find any highlights that intersect with what you've selected (our 1 and only highlight in this example) and then remove the whole thing.

I'm happy to submit a PR to add partial unhighlight ability, but first thought I'd see if anyone else has done this and/or if this project is still being maintained? Thanks,

@abrekken
Copy link
Author

abrekken commented Oct 20, 2017

Just an FYI, I have a PR out there for this.

@ZachSaucier
Copy link

The PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants