Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

Don't propagate touch to items behind a header (update StickyRecyclerHeadersTouchListener) #73

Merged
merged 2 commits into from Sep 8, 2015

Conversation

alexcohn
Copy link
Contributor

@alexcohn alexcohn commented Sep 1, 2015

When a sticky header is touched, a regular item behind it may receive the ACTION_DOWN event, and display "pressed" state. This commit fixes such undesired behavior by returning true for onInterceptTouchEvent() if it was DOWN inside the borders of a sticky header.

…items-behind-a-header-1

Don't propagate touch to items behind a header (update StickyRecyclerHeadersTouchListener)
@jacobtabak
Copy link
Contributor

Thanks! I'll test it out and update the sample to demonstrate the fix and then merge sometime soonish.

@alexcohn
Copy link
Contributor Author

alexcohn commented Sep 2, 2015

See the "demo" at alexcohn@73d9e9a

@jacobtabak
Copy link
Contributor

Thank you so much for pushing the updated sample. It really helps! I verified your fix and it works as expected.

We'll need to fix the indentation to match the rest of the project. Also, I think it would be great to add some javadocs here to explain what's going on. Would you mind doing that? I'm happy to do it if you're busy.

I'm planning on investing some time down the road cleaning this whole project up, adding checkstyle & tests to CI, and enhancing the documentation. So any documentation that we have now will make that process easier.

@alexcohn
Copy link
Contributor Author

alexcohn commented Sep 3, 2015

I would prefer if you take care of javadoc, to keep it all styled consistently. Regarding indentation, spaces, etc. feel free to fix

@jacobtabak
Copy link
Contributor

Thank you again! I'll touch up those things and we'll merge & release.

@jacobtabak jacobtabak merged commit 73d9e9a into timehop:master Sep 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants