Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniUI required but not installed #28

Open
KasperSkytte opened this issue Jun 18, 2018 · 4 comments
Open

miniUI required but not installed #28

KasperSkytte opened this issue Jun 18, 2018 · 4 comments

Comments

@KasperSkytte
Copy link
Contributor

Hi!

The miniUI package is required but not installed with the listviewer package. Maybe it should be?

if (!require(listviewer)) install.packages("listviewer")
#> Loading required package: listviewer
library(listviewer)
list <- list(a = 1, b = 2)
jsonedit_gadget(list)
#> Loading required namespace: miniUI
#> Failed with error:  ‘there is no package called ‘miniUI’’
#> Error in jsonedit_gadget(list): requireNamespace("miniUI") is not TRUE
@timelyportfolio
Copy link
Owner

Thanks so much for the report, but this is intentional to reduce the set of required dependencies. In the case of jsonedit_gadget, I consider this as non-core and ancillary. Hope this does not cause too much trouble.

@KasperSkytte
Copy link
Contributor Author

Alright. Mind if I make a PR where the user will be asked interactively to install the packages if they are not when they use jsonedit_gadget?

@timelyportfolio
Copy link
Owner

@KasperSkytte thanks so much for this. I expect to merge, but for some reason I feel like CRAN does not like for a package to be able to installed from another package in this way. I'll test locally to insure that this still passes CRAN checks, and if so will happily merge your pull request. Thanks again!!

@KasperSkytte
Copy link
Contributor Author

Alright, let's see. You're welcome and thank you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants