Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handover #1

Merged
merged 6 commits into from Feb 11, 2024
Merged

Handover #1

merged 6 commits into from Feb 11, 2024

Conversation

jovezhong
Copy link
Contributor

@jovezhong jovezhong commented Feb 11, 2024

Continue setting up the repo, as an early-stage Rust client lib for Proton.

Check list

https://github.com/timeplus-io/proton-rust-client/blob/main/Handover.md

  • Update MAINTAINERS.md, CODEOWNERS, and CONTRIBUTING.md
  • Update README
  • Verify CI / Github actions

The following actions to perform after this PR is merged to main branch

  • Publish the client to crates.io
  • Enable auto-release
  • Remove the Handover file

Routine check

  • All tests are passing when running make test?
  • No errors or security vulnerabilities are reported by make check?

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@jovezhong jovezhong marked this pull request as ready for review February 11, 2024 16:21
@marvin-hansen
Copy link
Contributor

Looks good to me. Proceed with merge

Copy link
Contributor

@marvin-hansen marvin-hansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@marvin-hansen marvin-hansen merged commit 4cc164e into main Feb 11, 2024
4 checks passed
@marvin-hansen marvin-hansen deleted the handover branch February 11, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants