Release 1.4.2

[svenklemm]

This maintenance release contains bugfixes since the 1.4.1 release. We deem it medium
priority for upgrading.

In particular the fixes contained in this maintenance release address 2 potential
segfaults and no other security vulnerabilities. The bugfixes are related to
background workers, OUTER JOINs, ordered append on space partitioned hypertables
and expression indexes.

[mfreed]

Is 1423 going in 1.4.2 or not? If so, should the notes be updated to say "release address one potential segfault" instead of 2?

Also, might be nice to have bugfix description point out where segfault happens in consistent manner so you can scan, which we can use going forward in our release notes:

e.g., Fix background worker SOMETHIGN (potential segfault) and Fix SOMETHING on ARM/32-bit builds (potential segfault).

Otherwise, LGTM.

[svenklemm]

1.4.x is not affected by #1423 but the count is still correct because #1392 was a segfault too

[mfreed]

Sounds good. I would then just reiterate that it would be a good thing to have bufgfix description mention that, e.g., #1392 Fix cagg_agg_validate expression handling (potential segfault)

I think this is useful when readers see the notes to determine whether upgrade is important for them, i.e., if they aren't using cagg or are ARM32, then nothing here is a segfault.

[cevian]

LGTM other than Mike's comment

[bboule]

Looks good from my end

[codecov]

Codecov Report

Merging #1430 into master will decrease coverage by 8.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1430      +/-   ##
==========================================
- Coverage   90.19%   81.23%   -8.97%     
==========================================
  Files         116      116              
  Lines       17471    16763     -708     
==========================================
- Hits        15758    13617    -2141     
- Misses       1713     3146    +1433

Flag	Coverage Δ
#cron	81.23% <ø> (-8.97%)	⬇️
#pr	81.23% <ø> (-0.22%)	⬇️

Impacted Files	Coverage Δ
tsl/src/nodes/gapfill/gapfill.c	45.45% <0%> (-54.55%)	⬇️
src/chunk_insert_state.c	31.62% <0%> (-54.42%)	⬇️
src/chunk.h	0% <0%> (-50%)	⬇️
src/utils.h	0% <0%> (-50%)	⬇️
src/plan_add_hashagg.c	46.87% <0%> (-40.63%)	⬇️
src/plan_expand_hypertable.c	43% <0%> (-40.62%)	⬇️
src/copy.c	44.67% <0%> (-37.99%)	⬇️
tsl/src/continuous_aggs/options.c	55.1% <0%> (-33.47%)	⬇️
src/scan_iterator.h	0% <0%> (-33.34%)	⬇️
src/with_clause_parser.c	53.7% <0%> (-29.94%)	⬇️
... and 84 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d793357...82b3d67. Read the comment docs.

[codecov]

Codecov Report

Merging #1430 into master will decrease coverage by 8.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1430      +/-   ##
==========================================
- Coverage   90.19%   81.22%   -8.98%     
==========================================
  Files         116      116              
  Lines       17471    16763     -708     
==========================================
- Hits        15758    13615    -2143     
- Misses       1713     3148    +1435

Flag	Coverage Δ
#cron	81.22% <ø> (-8.98%)	⬇️
#pr	81.22% <ø> (-0.23%)	⬇️

Impacted Files	Coverage Δ
tsl/src/nodes/gapfill/gapfill.c	45.45% <0%> (-54.55%)	⬇️
src/chunk_insert_state.c	31.62% <0%> (-54.42%)	⬇️
src/chunk.h	0% <0%> (-50%)	⬇️
src/utils.h	0% <0%> (-50%)	⬇️
src/plan_add_hashagg.c	46.87% <0%> (-40.63%)	⬇️
src/plan_expand_hypertable.c	43% <0%> (-40.62%)	⬇️
src/copy.c	44.67% <0%> (-37.99%)	⬇️
tsl/src/continuous_aggs/options.c	55.1% <0%> (-33.47%)	⬇️
src/scan_iterator.h	0% <0%> (-33.34%)	⬇️
src/with_clause_parser.c	53.7% <0%> (-29.94%)	⬇️
... and 84 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d793357...5199146. Read the comment docs.