Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-partial paths to parallel ChunkAppend #1467

Merged
merged 1 commit into from Oct 9, 2019

Conversation

svenklemm
Copy link
Member

No description provided.

@svenklemm svenklemm force-pushed the parallel_chunkappend4 branch 2 times, most recently from 29f1fee to 86797b3 Compare October 8, 2019 09:25
@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #1467 into master will increase coverage by <.01%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1467      +/-   ##
=========================================
+ Coverage   81.39%   81.4%   +<.01%     
=========================================
  Files         117     117              
  Lines       16894   16908      +14     
=========================================
+ Hits        13751   13764      +13     
- Misses       3143    3144       +1
Flag Coverage Δ
#cron 81.4% <94.73%> (ø) ⬆️
#pr 81.4% <94.73%> (ø) ⬆️
Impacted Files Coverage Δ
src/planner.c 85.98% <ø> (-0.13%) ⬇️
src/chunk_append/planner.c 80.45% <100%> (ø) ⬆️
src/chunk_append/chunk_append.c 87.02% <100%> (+0.3%) ⬆️
src/chunk_append/exec.c 95.69% <92.85%> (-0.16%) ⬇️
src/bgw/scheduler.c 82.28% <0%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc9a3e8...a0d79df. Read the comment docs.

@svenklemm svenklemm force-pushed the parallel_chunkappend4 branch 11 times, most recently from 5421dd4 to 4ed75fe Compare October 8, 2019 14:33
@svenklemm svenklemm requested a review from cevian October 8, 2019 15:25
Copy link
Contributor

@cevian cevian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a commit message body. Also is it possible to add some tests for this?

PostgreSQL will produce plans where a parallel append has children
that are not partial paths. This patch adds support for those plans
to ChunkAppend.
@svenklemm svenklemm merged commit 36bff37 into timescale:master Oct 9, 2019
@svenklemm svenklemm deleted the parallel_chunkappend4 branch October 10, 2019 13:45
@cevian cevian added the fixup label Oct 28, 2019
@cevian cevian added this to the 1.5.0 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants