Add next_start option to alter_job_schedule #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevian
force-pushed
the
add_next_start_to_alter_schedule
branch
from
30e0f30
to
5b43f58
Compare
Codecov Report
@@ Coverage Diff @@
## master #1479 +/- ##
=========================================
- Coverage 90% 81.4% -8.61%
=========================================
Files 116 116
Lines 17495 16934 -561
=========================================
- Hits 15747 13785 -1962
- Misses 1748 3149 +1401
Continue to review full report at Codecov.
|
davidkohn88
reviewed
Oct 11, 2019
| \c :TEST_DBNAME :ROLE_DEFAULT_PERM_USER | ||
| --not changing the interval doesn't change the next_start | ||
| select * from alter_job_schedule(:job_id, schedule_interval=>'20 min'); | ||
| WARNING: Timescale License expired |
There was a problem hiding this comment.
we probably shouldn't check license expiration on calls of this function if we've taken it out of enterprise
There was a problem hiding this comment.
but not sure if that's true/if we do it elsewhere...
JLockerman
approved these changes
Oct 11, 2019
Add the option to set the next start time on a job in the alter job schedule function. This also adds the ability to pause jobs by setting next_start to 'infinity' Also fix the enterprise licence check to only activate for enterprise jobs.
cevian
force-pushed
the
add_next_start_to_alter_schedule
branch
from
5b43f58
to
e0cc70e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option to set the next start time on a job in the
alter job schedule function. This also adds the ability
to pause jobs by setting next_start to 'infinity'
Also fix the enterprise licence check to only activate for
enterprise jobs.