Only use local clang-format 7 or 8 #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevian
approved these changes
Oct 15, 2019
CMakeLists.txt
Outdated
| @@ -277,7 +277,7 @@ if (CLANG_FORMAT) | |||
| message(FATAL_ERROR "Could not parse clang-format version ${CLANG_FORMAT_VERSION_OUTPUT}") | |||
| endif () | |||
|
|
|||
| if(${CMAKE_MATCH_1} LESS "7") | |||
| if((${CMAKE_MATCH_1} LESS "7") OR (${CMAKE_MATCH_1} GREATER "8")) | |||
| message(WARNING "clang-format is out of date (at least version 7 required)") | |||
There was a problem hiding this comment.
can we change the warning message? It's wrong for > 8.
clang-format > 8 has slightly different oppinion about source code formatting than earlier versions, unfortunately some of the new options cannot be set in a backwardscompatible way so we fall back to docker for newer versions.
svenklemm
force-pushed
the
clang-format
branch
from
46e0392
to
40b506d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1487 +/- ##
=========================================
Coverage ? 81.31%
=========================================
Files ? 114
Lines ? 16619
Branches ? 0
=========================================
Hits ? 13513
Misses ? 3106
Partials ? 0
Continue to review full report at Codecov.
|
svenklemm
force-pushed
the
clang-format
branch
from
40b506d
to
d6c1e62
Compare
cevian
added
the
build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format > 8 has slightly different oppinion about source code
formatting than earlier versions, unfortunately some of the new
options cannot be set in a backwardscompatible way so we fall back
to docker for newer versions.